This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: lto-plugin: mismatch between ld's architecture and GCC's configure --host


>> Ping.  To sum it up, with these patches applied, there are no changes for
>> a "regular" build (not using the new configure options).  On the other
>> hand, configuring GCC as described, it is possible use the 32-bit x86
>> linker for/with a x86_64 build, and get the very same GCC test results as
>> when using a x86_64 linker.

Sorry, I've been hoping someone with more global approval authority
would respond.

> Allow overriding the libiberty used for building the LTO plugin.
>
>         lto-plugin/
>         * configure.ac (--with-libiberty): New configure option.
>         * configure: Regenerate.
>         * Makefile.am (libiberty, libiberty_pic): New variables.
>         (liblto_plugin_la_LIBADD, liblto_plugin_la_LDFLAGS)
>         (liblto_plugin_la_DEPENDENCIES): Use them.
>         * Makefile.in: Regenerate.

These look OK to me.

> Allow for overriding a module's srcdir.
>
>         * Makefile.tpl (configure-[+prefix+][+module+])
>         (configure-stage[+id+]-[+prefix+][+module+]): Allow for
>         overriding a module's srcdir.
>         * Makefile.in: Regenerate.

These look OK, but I think a global maintainer or build machinery
maintainer should give approval.

> Non-host system configuration for linker plugins.
>
>         * configure.ac (--enable-linker-plugin-flags)
>         (--enable-linker-plugin-configure-flags): New flags.
>         (configdirs): Conditionally add libiberty-linker-plugin.
>         * configure: Regenerate.
>         * Makefile.def (host_modules): Add libiberty-linker-plugin.
>         (host_modules) <lto-plugin>: Pay attention to
>         @extra_linker_plugin_flags@ and
>         @extra_linker_plugin_configure_flags@.
>         (all-lto-plugin): Also depend on all-libiberty-linker-plugin.
>         * Makefile.in: Regenerate.
>         gcc/
>         * doc/install.texi (--enable-linker-plugin-flags)
>         (--enable-linker-plugin-configure-flags): Document new flags.

Same here.

> GNU ld can use linker plugins, too.
>
>         gcc/
>         * doc/sourcebuild.texi (Top Level) <lto-plugin>: GNU ld can use
>         linker plugins, too.

OK.

> Fix typo.
>
>         * Makefile.tpl: Fix typo.
>         * Makefile.in: Regenerate.

OK (qualifies as trivial and obvious).

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]