This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libsanitizer merge from upstream r191666
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Dodji Seketeli <dodji at redhat dot com>, Dmitry Vyukov <dvyukov at google dot com>
- Date: Sat, 2 Nov 2013 00:34:08 +0100
- Subject: Re: libsanitizer merge from upstream r191666
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdzrx07_OfvCcxm_uFUt3MRhg1gwqdHvmK_9kHDmz1vPVw at mail dot gmail dot com> <CAGQ9bdxj-DmEaoo0mOWfSVXsrhVShWj3onHZRxiwt97Vq6J45w at mail dot gmail dot com> <20131029121355 dot GY30970 at tucnak dot zalov dot cz> <CAGQ9bdw+VW=yF+vaqE_0GkyHUChL_vp3cABZf-FuNYoHo3g=eg at mail dot gmail dot com> <CAGQ9bdzHaBmaTnnX3=npLngK+8K1P2EWWMX-GmOLz0S1vWcHVA at mail dot gmail dot com> <CAGQ9bdxBgJJxv2gWzAsxuECoAV_zk4TWUVGeZiAnNF1gcEQJ7g at mail dot gmail dot com> <20131030070317 dot GA27813 at tucnak dot zalov dot cz> <CAGQ9bdz1FMOngnBBmuCU4UqyTNh_jvRr0=_psZMjCpoQj6zBiQ at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Nov 01, 2013 at 04:13:05PM -0700, Konstantin Serebryany wrote:
> 2013-10-XX Kostya Serebryany <kcc@google.com>
It is November now ;)
Looks good to me, except for a few ChangeLog issues:
> Update to match the changed asan API.
> * asan.c:
> (asan_function_start): New function.
Wrong ChangeLog formatting. The above should be:
* asan.c (asan_function_start): New function.
> (asan_emit_stack_protection): Update the string stored in the
> stack red zone to match new API. Store the PC of the current
> function in the red zone.
> (asan_global_struct): Update the __asan_global definition to match
> the new API.
> (asan_add_global): Ditto.
> * asan.h: Declare asan_function_start.
This should be:
* asan.h (asan_function_start): New prototype.
> * final.c:
> (final_start_function): Call asan_function_start.
Again, remove the first :, newline and whitespace (except for one space).
> * sanitizer.def: Rename __asan_init_v1 to __asan_init_v3.
* sanitizer.def (BUILT_IN_ASAN_INIT): Rename from __asan_init_v1
to __asan_init_v3.
>
> =========== libsanitizer/ChangeLog
>
> 2013-10-XX Kostya Serebryany <kcc@google.com>
>
> * All source files: Merge from upstream r191666.
> * merge.sh: Added lsan.
> * configure.ac: Added lsan.
* configure.ac (AC_CONFIG_FILES): Added lsan.
> * Makefile.am: Added lsan.
* Makefile.am (SUBDIRS): Add lsan.
> * sanitizer_common/Makefile.am: Added lsan.
That is not what you've changed. You've changed
* sanitizer_common/Makefile.am (sanitizer_common_files):
and changed formatting and added a few files, but nothing related to lsan.
> * asan/Makefile.am: Added dependency on lsan.
Again, list what you've changed there and describe the changes.
> * lsan/Makefile.am: New file.
> * asan/Makefile.in: Regenerate.
> * lsan/Makefile.in: Regenerate.
> * Makefile.in: Regenerate.
> * configure: Regenerate.
> * sanitizer_common/Makefile.in: Regenerate.
Ok with those changes.
Jakub