This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] LRA: Fix incorrect register spill/reload


On 11/01/13 14:39, David Edelsohn wrote:
On Fri, Nov 1, 2013 at 3:45 PM, Jeff Law <law@redhat.com> wrote:
On 10/31/13 14:03, Robert Suchanek wrote:

Hi David,

No, I do not have read/write SVN access. I know a person who could commit
the patch for me, however, if you can commit it, I'd be grateful.

Note, I didn't see anywhere in this thread an indication this test had been
through a bootstrap and regression testing.  I was running those overnight
on Robert's behalf and the bootstrap test failed with a comparison failure
between stage2/toplev.o and stage3/toplev.o

Vlad, when approving patches, please make sure they've been through the
usual bootstrap and regression testing procedures.  If the contributor
hasn't done it themselves, you can either do it for them or ask them to do
it.

I trust y'all will address the problem appropriately.

I bootstrapped on powerpc without problem, but Vlad earlier said that
the code applies to an x86 case.

I have not seen a deluge of complaints about bootstrap being broken.

Do you want me or Vlad to revert the patch? Or you will revert the patch?
I'm not in a rush to revert... I don't plan on doing anything on the trunk over the weekend. I'm comfortable waiting until Monday, both to see if anyone else trips over whatever is going wrong and to give Robert or anyone else time to debug.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]