This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][ubsan] Add VLA bound instrumentation

From: Jason Merrill <jason at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jakub Jelinek <jakub at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
Date: Wed, 30 Oct 2013 11:56:25 -0400
Subject: Re: [PATCH][ubsan] Add VLA bound instrumentation
Authentication-results: sourceware.org; auth=none
References: <20130912122655 dot GN23899 at redhat dot com> <20130925124132 dot GJ12296 at redhat dot com> <52697B9D dot 9000502 at redhat dot com> <20131025165803 dot GF27400 at redhat dot com> <526AB5CC dot 60408 at redhat dot com> <20131025190356 dot GG27400 at redhat dot com> <526AC0C9 dot 1050003 at redhat dot com> <20131030145253 dot GB31396 at redhat dot com>

On 10/30/2013 10:52 AM, Marek Polacek wrote:

+         if ((flag_sanitize & SANITIZE_VLA)
+             && !processing_template_decl

You don't need to check processing_template_decl; the template case wasalready handled above.

+             tree x = cp_save_expr (size);
+             x = build2 (COMPOUND_EXPR, TREE_TYPE (x),
+                         ubsan_instrument_vla (input_location, x), x);
+             finish_expr_stmt (x);

Saving 'size' here doesn't help since it's already been used above.Could you use itype instead of size here?


Jason

Follow-Ups:
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Marek Polacek

References:
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Jason Merrill
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Marek Polacek
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Jason Merrill
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Marek Polacek
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Jason Merrill
- Re: [PATCH][ubsan] Add VLA bound instrumentation
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]