This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Symtab, cgraph and varpool nodes are now a real class hierarchy


> 
> The conversion of the symtab types from inheritance-in-C to a C++ class
> hierarchy is now in trunk: I committed the manual parts of the
> conversion as r204170, and the automated part as r204171.  I then
> noticed that this broke the gdb debugging hooks for printing a
> (cgraph_node *).  I tested and committed the attached fix for them as
> r204174.
> 
> As a followup, I'm next looking at the renaming of the symtab types
> previously discussed with Honza (on 2013-09-10).

Thank you, David!

Honza
> 
> Dave

> Index: gcc/ChangeLog
> ===================================================================
> --- gcc/ChangeLog	(revision 204173)
> +++ gcc/ChangeLog	(revision 204174)
> @@ -1,3 +1,10 @@
> +2013-10-29  David Malcolm  <dmalcolm@redhat.com>
> +
> +	* gdbhooks.py (CGraphNodePrinter.to_string): Update gdb
> +	prettyprinter for cgraph_node to reflect the conversion of the
> +	symtable types to a C++ class hierarchy: it now *is* a
> +	symtab_node_base, rather than having one (named "symbol").
> +
>  2013-10-29  Balaji V. Iyer  <balaji.v.iyer@intel.com>
>  
>  	* builtins.c (is_builtin_name): Added a check for __cilkrts_detach and
> Index: gcc/gdbhooks.py
> ===================================================================
> --- gcc/gdbhooks.py	(revision 204173)
> +++ gcc/gdbhooks.py	(revision 204174)
> @@ -226,8 +226,7 @@
>              # symtab_node_name calls lang_hooks.decl_printable_name
>              # default implementation (lhd_decl_printable_name) is:
>              #    return IDENTIFIER_POINTER (DECL_NAME (decl));
> -            symbol = self.gdbval['symbol']
> -            tree_decl = Tree(symbol['decl'])
> +            tree_decl = Tree(self.gdbval['decl'])
>              result += ' "%s"' % tree_decl.DECL_NAME().IDENTIFIER_POINTER()
>          result += '>'
>          return result


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]