This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

From: Jeff Law <law at redhat dot com>
To: Andrew Pinski <pinskia at gmail dot com>, Zhenqiang Chen <zhenqiang dot chen at linaro dot org>
Cc: Richard Biener <richard dot guenther at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 28 Oct 2013 23:51:06 -0600
Subject: Re: [PATCH] Enhance ifcombine to recover non short circuit branches
Authentication-results: sourceware.org; auth=none
References: <CACgzC7AbQLh+uv=vzC51DiHjZZn12yEjvtrcyo61z7KjeYCe7Q at mail dot gmail dot com> <CA+=Sn1mm+3Zv9HxgGt4T_utu+-nsvhhCWRF-aWk05K=_704LRw at mail dot gmail dot com> <CAFiYyc2AgJg2r6mzQ69gYo2chBSRFgdVSkSnFU_tQXEanU+NGQ at mail dot gmail dot com> <52601731 dot 3000301 at redhat dot com> <CACgzC7BjGmkTZbor8Jr8ZpjN08JZUy-V64ExukG6HozK45=krw at mail dot gmail dot com> <CA+=Sn1nTd97wm7aWTmwKskZqzQZqC-a3cxW+p7GUH=CTnYTs-A at mail dot gmail dot com> <CA+=Sn1kZFa=+HRbk1kZZomX_rmujL=n+ZVqxEmtF6qvKpsYHUQ at mail dot gmail dot com> <CA+=Sn1k14xfavt02=1G4RWjdHC6BCvMpG0TrO5FKUEbxs6gkkA at mail dot gmail dot com>

On 10/27/13 12:55, Andrew Pinski wrote:

Here is my latest patch which adds the testcases from Zhenqiang's
patch and fixes item 1 and 2.

OK?  Bootstrapped and tested on x86_64-linux-gnu with no regressions.

Thanks,
Andrew Pinski

ChangeLog:
* tree-ssa-ifcombine.c: Include rtl.h and tm_p.h.
(ifcombine_ifandif): Handle cases where
maybe_fold_and_comparisons fails, combining the branches
anyways.
(tree_ssa_ifcombine): Inverse the order of
the basic block walk, increases the number of combinings.
* gimple.h (gsi_start_nondebug_after_labels_bb): New function.


testsuite/ChangeLog:

* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-1.c: New test case.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-2.c: New test case.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-3.c: New test case.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-4.c: New test case.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-5.c: New test case.
* gcc.dg/tree-ssa/ssa-ifcombine-ccmp-6.c: New test case.

* gcc.dg/tree-ssa/phi-opt-9.c: Use a function call to prevent
conditional move to be used.
* gcc.dg/tree-ssa/ssa-dom-thread-3.c: Remove check for "one or more
intermediate".

I don't be able to look at this in any depth tonight. However, I wouldask that you pass along the dump file for ssa-dom-thread-3.c so that Ican evaluate the correctness of your change better.


Thanks,
jeff

Follow-Ups:
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Andrew Pinski

References:
- [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Zhenqiang Chen
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Andrew Pinski
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Richard Biener
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Jeff Law
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Zhenqiang Chen
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Andrew Pinski
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Andrew Pinski
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Andrew Pinski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]