This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [SH] PR 54236 - add some more addc patterns


Oleg Endo <oleg.endo@t-online.de> wrote:
> This adds some more patterns to utilize the SH addc instruction.
> Tested on rev 204111 with
> make -k check RUNTESTFLAGS="--target_board=sh-sim
> \{-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4-single/-ml,-m4/-mb,-m4-single/-mb}"
> 
> and no new failures.
> OK for trunk?

Using same "*addc" for 7 different insn_and_split looks a bit
confusing.  It might be better to add some sufficies like
_r_1, _r_r_1, _r_1_r, _2r_1, _r_31, _r_r_31, _2r_31.
Other than that, the patch is OK.

Regards,
	kaz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]