This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] rewrite stack vectors
- From: Jeff Law <law at redhat dot com>
- To: Trevor Saunders <tsaunders at mozilla dot com>, Diego Novillo <dnovillo at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 28 Oct 2013 14:04:03 -0600
- Subject: Re: [PATCH] rewrite stack vectors
- Authentication-results: sourceware.org; auth=none
- References: <1381428442-13572-1-git-send-email-tsaunders at mozilla dot com> <526AC6E7 dot 6030305 at google dot com> <20131025195600 dot GA7399 at tsaunders-iceball dot corp dot tor1 dot mozilla dot com>
On 10/25/13 13:56, Trevor Saunders wrote:
On Fri, Oct 25, 2013 at 03:30:47PM -0400, Diego Novillo wrote:
On 2013-10-10 14:07 , email@example.com wrote:
This makes the implementation of stack vectors simpler and easier to use. This works by making the size of the on stack storage a template argument, so the
size is embedded in the type. This allows you to implicitly convert a
stack_vec<T, N> to a vec<T, va_heap> *, and it will just work. Because there's
no need to support stack vectors in unions we can make them be a more normal
c++ class with a constructor and destructor that are nontrivial.
Thanks. This looks much simpler, indeed. The patch is fine to
commit. Just a couple of observations/questions:
I don't have commit access, so can someone check it in for me? I
bootstrapped and got no changes in regression tests two weeks ago, but
haven't checked it since if that helps.
Bootstrap went fine (as expected). Installed on your behalf. Thanks!