This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix gcc.dg/20050922-*.c
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: Vidya Praveen <vidyapraveen at arm dot com>, gcc-patches at gcc dot gnu dot org, rearnsha at arm dot com, marcus dot shawcroft at arm dot com, janisjo at codesourcery dot com
- Date: Thu, 24 Oct 2013 22:33:37 -0400 (EDT)
- Subject: Re: [Patch] Fix gcc.dg/20050922-*.c
- Authentication-results: sourceware.org; auth=none
- References: <20131021102832 dot GB3343 at e103625-lin dot cambridge dot arm dot com> <5754744A-BD8A-4231-B481-B2AA44D9A48A at comcast dot net> <alpine dot BSF dot 2 dot 02 dot 1310241754300 dot 21715 at arjuna dot pair dot com>
On Thu, 24 Oct 2013, Hans-Peter Nilsson wrote:
> On Mon, 21 Oct 2013, Mike Stump wrote:
>
> > On Oct 21, 2013, at 3:28 AM, Vidya Praveen <vidyapraveen@arm.com> wrote:
> > > Tests gcc.dg/20050922-1.c and gcc.dg/20050922-2.c includes stdlib.h. This can
> > > be a issue especially since they define uint32_t.
> >
> > > OK for 4.7, 4.8?
> >
> > For release branches, you'd need to transition from the
> > theoretical to the practical. On which systems (software)
> > does
> > it fail? If none, then no, a back port isn't necessary. If
> > it
> > fails on a system (or software) on which real users use, then
> > I'll approve it once you name the system (software) and let it
> > bake on trunk for a week and see if anyone objects?
>
> I too would like to include this change on those branches, as
> recent generic newlib changes has caused these tests to break
> (regress) for my autotester for cris-elf testing those branches.
Uhm, I'm on the fence, half-way wanting to retract my
suggestion. This seems a recent bug in newlib, in which e.g.
#include <stdlib.h> causes uint32_t to be defined, bleeding from
newlib-internal include of stdint.h. On the other hand, testing
that bleed isn't the purpose of these tests.
brgds, H-P