This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)
- From: Diego Novillo <dnovillo at google dot com>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Jeff Law <law at redhat dot com>, Andrew Macleod <amacleod at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 22 Oct 2013 08:46:13 -0400
- Subject: Re: [PATCH][buildrobot] tilepro/tilegx: fallout after tree.h refactoring (was: Re-factor inclusion of tree.h)
- Authentication-results: sourceware.org; auth=none
- References: <20131021165218 dot GA18836 at google dot com> <52655D12 dot 5020602 at redhat dot com> <CAD_=9DTjEzu_Yo9ZGbsQUGV+1sRyB=u+H=fO3Q5Pp1aHhJEm3g at mail dot gmail dot com> <20131022082233 dot GM19160 at lug-owl dot de>
On Tue, Oct 22, 2013 at 4:22 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Mon, 2013-10-21 15:36:49 -0400, Diego Novillo <dnovillo@google.com> wrote:
>> Can anyone think of some way that we can use to automatically block
>> inclusions of tree.h from header files? Code review is the only way
>> that comes to mind.
>
> Grep once, then install a commit hook.
Hm, that may work. Thanks.
> I get some fallout for tilepro-linux, see
> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=21851 .
Sorry about that. I missed it in my testing because tilepro-linux-gnu
fails early in libcpp with:
../../../gcc/libcpp/macro.c:2965:58: error: format not a string
literal and no format arguments [-Werror=format-security]
../../../gcc/libcpp/macro.c:2978:58: error: format not a string
literal and no format arguments [-Werror=format-security]
> This fixes it:
>
> 2013-10-22 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/tilepro/tilepro.c: Include "tree.h".
Sure. It qualifies as obvious. Thanks.
Diego.