This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins


On 21 Oct 12:08, Joseph S. Myers wrote:
> On Mon, 21 Oct 2013, Ilya Enkovich wrote:
> 
> > +  if (flag_check_pointers)
> > +    {
> > +      if (flag_lto)
> > +	sorry ("Pointers checker is not yet fully supported for link-time optimization");
> 
> That sounds wrong.  It suggests some bug somewhere in your patch series 
> failing to allow for LTO, which should be fixed.  At least give a more 
> detailed explanation in a comment of what would need to change to remove 
> this call to sorry ().

It has been a while since I saw problem with LTO (some functions appeared to miss instrumentation; it seemed compilation flags for checker were not handled correctly for some reason).  When I made this branch public I put this guard to prevent users from falling into this problem.  Actually I do not know what is the current status of that issue.  A lot of things has changed including checker flags definition.  I'll try mpx testsuite with LTO and be back with the result.

> 
> > +      if (targetm.chkp_bound_mode () == VOIDmode)
> > +	error ("-fcheck-pointers is not supported for this target.");
> 
> Also note GNU Coding Standards for diagnostics.  They should not start 
> with uppercase letters or end with ".".

Thanks for input! I'll fix it.

Thanks,
Ilya

> 
> -- 
> Joseph S. Myers
> joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]