This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR58682
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Paulo Matos <pmatos at broadcom dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Mike Stump <mikestump at comcast dot net>, Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Jan Hubicka (hubicka at ucw dot cz)" <hubicka at ucw dot cz>
- Date: Mon, 21 Oct 2013 14:21:22 +0200
- Subject: Re: [PATCH] Fix PR58682
- Authentication-results: sourceware.org; auth=none
- References: <5256D283 dot 7090000 at arm dot com> <19EB96622A777C4AB91610E763265F462D97A9 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <19EB96622A777C4AB91610E763265F462DB4E2 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <19EB96622A777C4AB91610E763265F462DB4F8 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <525BCADE dot 8040306 at arm dot com> <EB210B59-0645-4C3D-B7DD-56B4A64F6A22 at comcast dot net> <19EB96622A777C4AB91610E763265F462DEAC2 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <19EB96622A777C4AB91610E763265F462E18DA at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <CAFiYyc2z_++BKiOD9OHDSQ603tBB9mOuWpoRZVNLHQEL4B_cxw at mail dot gmail dot com> <19EB96622A777C4AB91610E763265F462E31CD at SJEXCHMB14 dot corp dot ad dot broadcom dot com>
> > -----Original Message-----
> > From: Richard Biener [mailto:richard.guenther@gmail.com]
> > Sent: 18 October 2013 13:12
> > To: Paulo Matos
> > Cc: Mike Stump; Kyrill Tkachov; gcc-patches@gcc.gnu.org
> > Subject: Re: [PATCH] Fix PR58682
> >
> > Please re-post the latest version of the patch and CC Honza.
> >
> > Richard.
> >
>
> Patch attached. OK to submit?
> Bootstrapped x86_64-unknown-linux-gnu.
>
> 2013-10-21 Paulo Matos <pmatos@broadcom.com>
>
> * ipa-inline.c (inline_small_functions): Update max_count if new edges
> are found after inlining.
This won't work - the max_count is there to get things correctly scaled by badness calculation.
Changing max_count would mean the need to recompute all badnesses in the fibheap keys.
I would just cap the edge_count in badness calculation.
Honza
>
> --
> Paulo Matos