This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR58682


> > -----Original Message-----
> > From: Richard Biener [mailto:richard.guenther@gmail.com]
> > Sent: 18 October 2013 13:12
> > To: Paulo Matos
> > Cc: Mike Stump; Kyrill Tkachov; gcc-patches@gcc.gnu.org
> > Subject: Re: [PATCH] Fix PR58682
> >  
> > Please re-post the latest version of the patch and CC Honza.
> > 
> > Richard.
> > 
> 
> Patch attached. OK to submit?
> Bootstrapped x86_64-unknown-linux-gnu.
> 
> 2013-10-21  Paulo Matos  <pmatos@broadcom.com>
> 
> 	* ipa-inline.c (inline_small_functions): Update max_count if new edges
> 	are found after inlining.

This won't work - the max_count is there to get things correctly scaled by badness calculation.
Changing max_count would mean the need to recompute all badnesses in the fibheap keys.
I would just cap the edge_count in badness calculation.

Honza

> 
> -- 
> Paulo Matos



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]