This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, SH] Add support for inlined builtin-strcmp (2/2)


Hi Oleg,

On 10/19/2013 11:30 AM, Oleg Endo wrote:

>
>
> I've attached two test cases, tested with 
> make -k check-gcc RUNTESTFLAGS="sh.exp=strcmp* --target_board=sh-sim
> \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}"
>
> Could you please include them?
>
> Cheers,
> Oleg
>
>
thanks for having retested this,  The tests are still not complete for 
RTL generated functions, there are cases where no str/cmp wil be
emitted, because we can predict than the size is less than 4 and so have
a direct fallthru into the byte at a byte loop copying.

Also I will consider a size optimized implementation, so we don't jump
to the library

I will post examples for this shortly (and add them as a testcase) with
a strncmp implementation helper, that pertains to strcmp with constant
strings by the way. Please allow me some time to complete by benchmarking.

thanks  for the hints about removing empty "" is the expanders

Kaz, before proceeding with the next patch, was your approval for 1/2
only or 2/2 with the expander cleanup ?

Many thanks,

Christian





Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]