This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, SH] Add support for inlined builtin-strcmp (2/2)
- From: Christian Bruel <christian dot bruel at st dot com>
- To: Oleg Endo <oleg dot endo at t-online dot de>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Date: Sun, 20 Oct 2013 14:24:18 +0200
- Subject: Re: [PATCH, SH] Add support for inlined builtin-strcmp (2/2)
- Authentication-results: sourceware.org; auth=none
- References: <525FF0F9 dot 4010704 at st dot com> <1382051119 dot 2445 dot 62 dot camel at yam-132-YW-E178-FTW> <5260EA68 dot 9080603 at st dot com> <1382175042 dot 2445 dot 84 dot camel at yam-132-YW-E178-FTW>
On 10/19/2013 11:30 AM, Oleg Endo wrote:
> I've attached two test cases, tested with
> make -k check-gcc RUNTESTFLAGS="sh.exp=strcmp* --target_board=sh-sim
> Could you please include them?
thanks for having retested this, The tests are still not complete for
RTL generated functions, there are cases where no str/cmp wil be
emitted, because we can predict than the size is less than 4 and so have
a direct fallthru into the byte at a byte loop copying.
Also I will consider a size optimized implementation, so we don't jump
to the library
I will post examples for this shortly (and add them as a testcase) with
a strncmp implementation helper, that pertains to strcmp with constant
strings by the way. Please allow me some time to complete by benchmarking.
thanks for the hints about removing empty "" is the expanders
Kaz, before proceeding with the next patch, was your approval for 1/2
only or 2/2 with the expander cleanup ?