This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 7/8] Remove basic-block.h from cgraph.h


On 10/18/13 07:43, Andrew MacLeod wrote:
I also happened to notice that basic-block.h was being included directly
by cgraph.h.  The only thing cgraph.h and most of what use it need are
the typedefs for gcov_type:

typedef HOST_WIDEST_INT gcov_type;
typedef unsigned HOST_WIDEST_INT gcov_type_unsigned;

This patch moves gcov_type and gcov_type_unsigned to coretypes.h.

I will note this is the first time HWINT is introduced to coretypes, but
I believe system.h is suppose to always be included first, and that
includes HWINT.  we could also include HWINT from coretypes... But Im
not sure what the standard practice for what goes into coretypes
actually is.

In any case, by removing the basic-block.h include from cgraph.h,
varasm.c was the only .c file that required a new include.

Does this seem reasonable?

bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK?
OK.

I'm not sure if we have a hard and fast rule, but I'm certainly OK with making one that we have config.h, system.h, coretypes.h as the defined order.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]