This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libbacktrace patch committed (Was: Re: [jit] Update TODO.rst)


On Thu, 2013-10-17 at 21:28 -0700, Ian Lance Taylor wrote:
> On Thu, Oct 17, 2013 at 8:54 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> >
> > +* segfault seen in libbacktrace, when an ICE occurs
> 
> That reminded me to commit this libbacktrace patch I worked up a
> couple of weeks ago.  Previously if some debug section was missing,
> the code could compute the wrong min_offset.  The missing section
> would have a zero offset, so min_offset would be set to zero, and
> would then be set to the offset of the next section, even though that
> one might not be the minimum.  That could lead to a segfault in some
> cases, though I don't know if that is the issue that David is seeing.

Thanks - your patch has fixed the issue I was seeing, and I now reliably
get backtraces when an ICE happens within libgccjit.so.

Now to try to fix things so that ICEs can't happen...

Dave


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]