This is the mail archive of the
mailing list for the GCC project.
Re: libbacktrace patch committed (Was: Re: [jit] Update TODO.rst)
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, jit at gcc dot gnu dot org
- Date: Fri, 18 Oct 2013 09:38:46 -0400
- Subject: Re: libbacktrace patch committed (Was: Re: [jit] Update TODO.rst)
- Authentication-results: sourceware.org; auth=none
- References: <CAKOQZ8w2+iNGEo-J5qid_D_jbLW4F17BfOKUm1yLOT5RDAa7Pw at mail dot gmail dot com>
On Thu, 2013-10-17 at 21:28 -0700, Ian Lance Taylor wrote:
> On Thu, Oct 17, 2013 at 8:54 PM, David Malcolm <email@example.com> wrote:
> > +* segfault seen in libbacktrace, when an ICE occurs
> That reminded me to commit this libbacktrace patch I worked up a
> couple of weeks ago. Previously if some debug section was missing,
> the code could compute the wrong min_offset. The missing section
> would have a zero offset, so min_offset would be set to zero, and
> would then be set to the offset of the next section, even though that
> one might not be the minimum. That could lead to a segfault in some
> cases, though I don't know if that is the issue that David is seeing.
Thanks - your patch has fixed the issue I was seeing, and I now reliably
get backtraces when an ICE happens within libgccjit.so.
Now to try to fix things so that ICEs can't happen...