This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>, DJ Delorie <dj at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, Graham Stott <graham dot stott at btinternet dot com>, james dot greenhalgh at arm dot com, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Fri, 18 Oct 2013 13:24:53 +0200
- Subject: Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS
- Authentication-results: sourceware.org; auth=none
- References: <CAFiYyc3o+GLpPnNb=E1ru9rOJxuVkxBMsMEeE99wRm8SRWrmCg at mail dot gmail dot com> <1378833157-11511-1-git-send-email-james dot greenhalgh at arm dot com> <87y574mr2h dot fsf at talisman dot default> <1378900963 dot 71148 dot YahooMailNeo at web87402 dot mail dot ir2 dot yahoo dot com> <87y573kxse dot fsf at talisman dot default> <CAFiYyc1aR91hKgkGMbLfVtH0vmXOBPruaiPRqQ5-FCA5gTDMWg at mail dot gmail dot com> <87ppseko71 dot fsf at talisman dot default> <CAFiYyc36vmFX0HneNXQFcBT5ajGZ2fapVCX08DBR-x+LY7h1mQ at mail dot gmail dot com> <87d2odkuu7 dot fsf at talisman dot default> <0F11E779-5DA9-43E6-A12F-64A66B147AF7 at comcast dot net> <CAFiYyc0r-5_u+f0HKRNZpRH8NBZKcrV=F+TFMYX7mb0yQbEMMA at mail dot gmail dot com> <792D0DC7-4751-438F-A40A-94168CBA7F9E at comcast dot net> <201309170341 dot r8H3fnTD032129 at greed dot delorie dot com> <FC31B5DC-CF0F-4D5A-B2A7-63E4B7ACD0F6 at comcast dot net> <87txhjic2a dot fsf at talisman dot default>
On Tue, Sep 17, 2013 at 7:37 PM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> Mike Stump <mikestump@comcast.net> writes:
>> +/* Partial integer modes are specified by relation to a full integer
>> + mode. */
>> +#define PARTIAL_INT_MODE(M,PREC) \
>> + make_partial_integer_mode (#M, "P" #PREC #M, PREC, __FILE__, __LINE__)
>> +/* Partial integer modes are specified by relation to a full integer
>> + mode. */
>> +#define PARTIAL_INT_MODE_NAME(M,PREC,NAME) \
>> + make_partial_integer_mode (#M, #NAME, PREC, __FILE__, __LINE__)
>
> Sorry for the bikeshedding, but I think it'd better to have a single macro:
>
> #define PARTIAL_INT_MODE(M, PREC, NAME)
>
> You can easily add an explicit "P<n><mode>" if the port happens to want
> that name.
I agree. Btw, the "implementation defined" precision of PDI on SH-5 definitely
looks interesting, but I wonder how you can perform "implementation defined"
arithmetic on that PDI mode then ;) I suppose using the maximum precision
of 64 bits is good enough, assuming the rest of the bits get truncated in
"implementation defined" manners.
What else blocks this patch?
Thanks,
Richard.
> Thanks,
> Richard