This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,ARM] fix testsuite failures for arm-none-linux-gnueabihf

Committed on Charles' behalf as rev 203799 with this ChangeLog entry:
2013-10-17  Charles Bayis  <>

* gcc.dg/builtin-apply2.c: Skip test on arm hardfloat ABI targets.
* gcc.dg/tls/pr42894.c: Remove dg-options for arm*-*-* targets.
* Remove dg-skip-if and require
effective target arm_thumb1_ok.
* lib/target-supports.exp
(check_effective_target_arm_fp16_ok_nocache): Don't force
-mfloat-abi=soft when building for hardfloat target.

(sorry, despite selecting 'plain text mode', gmail seems to change formatting)


On 17 October 2013 12:39, Jakub Jelinek <> wrote:
> On Thu, Oct 17, 2013 at 11:32:42AM +0100, Richard Earnshaw wrote:
>> On 19/09/13 18:21, Charles Baylis wrote:
>> > Here is an updated version.
>> >
>> > Changelog:
>> >
>> >         * gcc.dg/builtin-apply2.c: skip test on arm hardfloat ABI targets
>> >         * gcc.dg/tls/pr42894.c: Remove options, forcing -mthumb fails
>> > with hardfloat, and test is not thumb-specific
>> >         * gcc,target/arm/thumb-ltu.c: Avoid test failure with
>> > hardfloat ABI by requiring arm_thumb1_ok
>> >         * lib/target-supports.exp
>> > (check_effective_target_arm_fp16_ok_nocache): don't force
>> > -mfloat-abi=soft when building for hardfloat target
>> >
>> ChangeLogs should be formatted to 80 columns.
> Not only that.  The descriptions should start with capital letter
> and end with a dot.  For pr42894.c, you are not removing options,
> you are removing dg-options, and the rest is why, not what, so doesn't
> belong into the ChangeLog description.  Similarly, for thumb-ltu.c,
> what are doing is remove dg-skip-if and require affective target
> arm_thumb1_ok.
>         Jakub

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]