This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][i386]Fix PR 57756


On Thu, Oct 17, 2013 at 10:23:27AM -0700, Sriraman Tallam wrote:
> I would need the help of target maintainers to fix it this way since
> it touches every target and it would take time for me to build and
> test every target.
> 
> Michael, OTOH, I dont see any other targets other than i386 and rs6000
> (grepping for "specific_save" and "specific_restore") using
> function_specific save and restore functions. Would it be easier then
> to just add back that line to "opth-gen.awk"?,the patch is below.
> Since, they are not using function specific opts, they presumably
> should not be validating target options a lot.

I believe only x86 and powerpc use the target specific feature (that I added
for x86 in the 4.3 time frame, and then added to powerpc last year).

In terms of target_flags and target_flags_explicit, the powerpc no longer uses
this field, since we have more than 32 flag bits, and needed to move the flag
processing to something that is HOST_WIDE_INT sized instead of int sized.  So,
it won't matter if you redefine the flag once again.  I don't believe the x86
uses it either (for much the same reason).  So, if it fixes the other ports, I
would say it is ok (but I haven't looked in detail at it).

-- 
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]