This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][i386]Fix PR 57756


On Thu, Oct 17, 2013 at 9:28 AM, Steve Ellcey <sellcey@mips.com> wrote:
> On Thu, 2013-10-17 at 06:03 -0700, Diego Novillo wrote:
>> On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
>>
>> > How is Google going to change its patch commit policies to ensure that
>> > this does not happen again?
>>
>> There is nothing to change.  Google follows
>> http://gcc.gnu.org/contribute.html, like everyone else. Sri just fixed
>> the oversight and if there is any other fallout from his patch, he
>> will address it.
>>
>> I don't see anything out of the ordinary here.
>>
>>
>> Diego.
>
> FYI: I just want to make sure everyone is aware that there are still
> broken targets.  rs6000 may be fixed but mips still doesn't work and
> I presume other platforms like sparc are also still broken.
>
> /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c: In
> function 'void cpp_atomic_builtins(cpp_reader*)':
> /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:594:7: error: 'target_flags_explicit' was not declared in this scope
> /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:606:7: error: 'target_flags_explicit' was not declared in this scope
> /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:618:7: error: 'target_flags_explicit' was not declared in this scope
> /local/home/sellcey/nightly_full/src/gcc/gcc/c-family/c-cppbuiltin.c:630:7: error: 'target_flags_explicit' was not declared in this scope
> make[1]: *** [c-family/c-cppbuiltin.o] Error 1
>
> Sriraman, are you looking at how to fix this globally or are the target
> maintainers expected to fix this?  Currently I am using this one line
> patch to get things building, but I presume this is not what we want
> long term.

Yes, I am on it. I will get back asap.


Sri


>
>
> % git diff opth-gen.awk
> diff --git a/gcc/opth-gen.awk b/gcc/opth-gen.awk
> index 01c5ab6..46bd570 100644
> --- a/gcc/opth-gen.awk
> +++ b/gcc/opth-gen.awk
> @@ -114,6 +114,7 @@ print "};"
>  print "extern struct gcc_options global_options;"
>  print "extern const struct gcc_options global_options_init;"
>  print "extern struct gcc_options global_options_set;"
> +print "#define target_flags_explicit global_options_set.x_target_flag
> s"
>  print "#endif"
>  print "#endif"
>  print ""
>
>
> Steve Ellcey
> sellcey@mips.com
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]