This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][i386]Fix PR 57756

On Wed, Oct 16, 2013 at 04:23:56PM -0700, Sriraman Tallam wrote:
> On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner
> <> wrote:
> > On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote:
> >> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra <> wrote:
> >> > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote:
> >> >> I committed this patch after making the above change.
> >> >
> >> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c: At global scope:
> >> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from âvoid (*)(cl_target_option*)â to âvoid (*)(cl_target_option*, gcc_options*)â [-fpermissive]
> >> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from âvoid (*)(cl_target_option*)â to âvoid (*)(gcc_options*, cl_target_option*)â [-fpermissive]
> >>
> >> This patch fixes it, ok to submit?
> >
> > No.  I have just committed a fix for this.  Your patch does not replicate the
> > rs6000_isa_flags_explicit field to be a GCC option.  Presumably the intent of
> > the 57756 patch was to remove references to the global variables.  Your patch
> > still references those variables.  What I did was to move the isa explicit flag
> > to be a target variable, so that it is preserved in the gcc_options structure
> > like everything else.
> >
> > However, I wonder why you committed the original changes with changes to the
> > powerpc backend, and DID NOT build a powerpc and fix the compilation errors.
> I was unable to build a native powerpc compiler. I checked for
> build_target_node and build_optimization_node throughout and changed
> rs6000 because it had references. I did not realize
> function_specific_save and function_specific_restore have to be
> changed. Sorry for breaking it.

The gcc110 machine in the compile farm can be used to build native powerpc64
toolchains.  In addition, the problem would have shown up if you had built a
cross compiler.

You presumably missed the references in rs6000.h that defined
rs6000_isa_flags_explicit as using the global_options_set structure.

Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
email:, phone: +1 (978) 899-4797

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]