This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][i386]Fix PR 57756


On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner
<meissner@linux.vnet.ibm.com> wrote:
> On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote:
>> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra <amodra@gmail.com> wrote:
>> > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote:
>> >> I committed this patch after making the above change.
>> >
>> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c: At global scope:
>> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from ‘void (*)(cl_target_option*)’ to ‘void (*)(cl_target_option*, gcc_options*)’ [-fpermissive]
>> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from ‘void (*)(cl_target_option*)’ to ‘void (*)(gcc_options*, cl_target_option*)’ [-fpermissive]
>>
>> This patch fixes it, ok to submit?
>
> No.  I have just committed a fix for this.  Your patch does not replicate the
> rs6000_isa_flags_explicit field to be a GCC option.  Presumably the intent of
> the 57756 patch was to remove references to the global variables.  Your patch
> still references those variables.  What I did was to move the isa explicit flag
> to be a target variable, so that it is preserved in the gcc_options structure
> like everything else.
>
> However, I wonder why you committed the original changes with changes to the
> powerpc backend, and DID NOT build a powerpc and fix the compilation errors.

I was unable to build a native powerpc compiler. I checked for
build_target_node and build_optimization_node throughout and changed
rs6000 because it had references. I did not realize
function_specific_save and function_specific_restore have to be
changed. Sorry for breaking it.

Sri

>
> 2013-10-16  Michael Meissner  <meissner@linux.vnet.ibm.com>
>
>         PR target/57756
>         * config/rs6000/rs6000.opt (rs6000_isa_flags_explicit): Move the
>         explicit isa flag to be an options variable, instead of using
>         global_options_set.  Remove define from rs6000.h.
>         * config/rs6000/rs6000.h (rs6000_isa_flags_explicit): Likewise.
>
>         * config/rs6000/rs6000.c (rs6000_option_override_internal):
>         Initialize rs6000_isa_flags_explicit.
>         (rs6000_function_specific_save): Add gcc_options* parameter, so
>         that the powerpc builds after the 2013-10-15 changes.
>         (rs6000_function_specific_restore): Likewise.
>
> --
> Michael Meissner, IBM
> IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
> email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]