This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).

From: Chung-Ju Wu <jasonwucj at gmail dot com>
To: Chung-Ju Wu <jasonwucj at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, rdsandiford at googlemail dot com
Date: Wed, 16 Oct 2013 20:48:12 +0800
Subject: Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
Authentication-results: sourceware.org; auth=none
References: <CADj25HMFJUOHWC5ZvDOrJH+xkCoN8sxHXhD2vb36bM95irWEdg at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1307092307170 dot 29921 at digraph dot polyomino dot org dot uk> <51EFF75C dot 2070705 at gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1307241606370 dot 31023 at digraph dot polyomino dot org dot uk> <51F0F15E dot 1050606 at gmail dot com> <522CA211 dot 60200 at gmail dot com> <8761u4losy dot fsf at talisman dot default> <5245CAB9 dot 8050400 at gmail dot com> <87siwnlvi5 dot fsf at talisman dot default> <52505830 dot 9080800 at gmail dot com> <87pprispu3 dot fsf at talisman dot default> <52541E04 dot 3010303 at gmail dot com> <87k3hnr1op dot fsf at talisman dot default> <525A9203 dot 6020708 at gmail dot com> <871u3p9l5i dot fsf at talisman dot default>

2013/10/14 Richard Sandiford <rdsandiford@googlemail.com>:
> Chung-Ju Wu <jasonwucj@gmail.com> writes:
>> +                                                  push_p ? false : true,
>
> Minor nit, but I think the normal GCC style would be to use !push_p here.
>

Ah~ yes, thank you for the catch.
Modify it accordingly.

A revised-5 patch for nds32.c is attached. :)

> Thanks for your patience in dealing with all my comments.  All three
> subparts look good to me with the change above and the ones mentioned
> in the (2) thread.  Hope the port gets accepted.
>
> Thanks,
> Richard

Thank you for your technical review in these days.
All of our compiler engineers at Andes Technology Corporation
greatly appreciate your guidance in machine description design.

I will post final v4 patches of nds32 port on the gcc-patches
and see whether global reviewers have other comments.
Thank you very much. :)

Best regards,
jasonwucj

Attachment: 2-nds32-backend-md-part1.v3.revised-5.patch
Description: Binary data

References:
- Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
  - From: Chung-Ju Wu
- Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
  - From: Richard Sandiford
- Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
  - From: Chung-Ju Wu
- Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
  - From: Richard Sandiford
- Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
  - From: Chung-Ju Wu
- Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]