This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] Fix libgfortran cross compile configury w.r.t newlib
- From: Mike Stump <mikestump at comcast dot net>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, Steve Ellcey <sellcey at mips dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- Date: Tue, 15 Oct 2013 14:35:06 -0700
- Subject: Re: [PATCH v2] Fix libgfortran cross compile configury w.r.t newlib
- Authentication-results: sourceware.org; auth=none
- References: <52443AFE dot 5050802 at arm dot com> <1380298134 dot 5988 dot 61 dot camel at ubuntu-sellcey> <52497156 dot 5010203 at arm dot com> <524AB4AD dot 6070508 at arm dot com> <CAFqB+PxJR53JGV3f8dy7SNRHbdVMc0aqAC5ruFC6S0WXtksE5w at mail dot gmail dot com> <525DA2D7 dot 5080509 at net-b dot de>
On Oct 15, 2013, at 1:17 PM, Tobias Burnus <burnus@net-b.de> wrote:
> Marcus Shawcroft wrote:>> 2013-10-01 Marcus Shawcroft <marcus.shawcroft@arm.com>
> >>
> >> * configure.ac (AC_CHECK_FUNCS_ONCE): Add for exit() then make
> >> existing AC_CHECK_FUNCS_ONCE dependent on outcome.
> >
> > Ping^2
>
> For configure patches, I am never quite sure whether they should be reviewed by a build maintainer or by the library maintainer. In any case, the change looks reasonable to me and as no other newlib user has complained, it is also okay from my side.
Would be nice for a build/config person to weigh in or to upgrade and make bullet proof the system against such failures. My take, by default, the compile line should do something useful, and that should be enough for autoconf style tests to smell the library. Now, we can observe that Steve's mips-mti-elf newlib port apparently violates that, but it is lost on me why that is and why that is a good thing. Steve? Is there some reason why by default, a suitable linker script can't be added by the compiler, or, if none suitable, a stub one that isn't suitable in general, but, is complete enough to allow autoconf to function normally?