This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libgomp.texi: Update for OpenMP v4.0

On Tue, Oct 15, 2013 at 10:13:32PM +0200, Tobias Burnus wrote:
> I used texinfo 4.14a to create the PDF and info file, which didn't
> show any warning. Also the output looks okay. (However, I believe
> some newer texinfo is picker.)
> OK for the trunk?

Thanks.  Just a few nits:

> +@node omp_set_default_device
> +@section @code{omp_set_default_device} -- Set the default device for target regions
> +@table @asis
> +@item @emph{Description}:
> +Set the default device for target regions without device clause.  The argument
> +shall be a positive device number.

non-negative, 0 is a valid target device number.

> +@section @env{OMP_CANCELLATION} -- Set whether cancellation is activated
> +@cindex Environment Variable
> +@table @asis
> +@item @emph{Description}:
> +If set to @code{TRUE}, the cancellation is activated.  If set to @code{FALSE} or
> +if unset, cancellation is disabled and the @code{cancel} construct is ignored.

Perhaps mention that the default is @code{FALSE}?

> +@section @env{OMP_DEFAULT_DEVICE} -- Set the device used in target regions
> +@cindex Environment Variable
> +@table @asis
> +@item @emph{Description}:
> +Set to choose the device which is used in a @code{target} region, unless the
> +value is overridden by @code{omp_set_default_device} or by a @code{device}
> +clause.  The value shall be the positive device number or @code{0} to execute

non-negative; 0 doesn't force execution on host (well, right now everything
is executed on the host, but hopefully that will change in the future), only
numbers equal or above omp_get_num_devices () do.

> +on the host.  If unset, code in a @code{target} region is executed on the host.

Nope, the default will be probably 0, first target device if present.

> +Alternatively, the placement can be specified explicitly as comma-separated
> +list of places.  A place is specified by set of nonnegative numbers in curly
> +braces, denoting the denoting the hardware threads.  The hardware threads
> +belonging to a place can either be specified as comma-separated list of
> +nonnegative thread numbers or using an interval.  Multiple places can also be
> +either specified by a comma-separated list of places or by an interval.  To
> +specify an interval, a colon with the number of threads which shall be in the
> +interval is placed after after the hardware thread number or the place.
> +Optionally, the length can be followed by a colon and the stride number --
> +otherwise a unit stride is assumed.  For instance, the following specifies the
> +same places list: @code{"@{0,1,2@}, @{3,4,6@}, @{7,8,9@}, @{10,11,12@}"};
> +@code{"@{0:2@}, @{3:6@}, @{7:9@}, @{10:12@}"}; and @code{"@{0:2@}:4:3"}.

The number after : is count, not end, so you want here
{0:3}, {3:3}, {7:3}, {10:3} resp. {0:3}:4:3.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]