This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 4/4] Add documentation about gengtype and inheritance


On 09/24/13 11:49, David Malcolm wrote:
gcc/
	* doc/gty.texi (GTY Options): Add note about inheritance to
	description of desc and tag.
	(Inheritance and GTY): New.
So what happens if I have a class hierarchy without a gty-user marker which violates the assumptions made by your new code?

I'm not worried about existing code with gty-user markers as I can easily see how those are avoided. I'm thinking more of new code where the author isn't as familiar with the gty machinery as they should be or in the future if we're using this stuf extensively and someone mucks around with the class hierarchy and breaks one of the assumptions. I just want to make sure those two cases fail-safe.

As for this patch, it is OK once the prerequisites go in.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]