This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] tree_code_name wrapper
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Paulo Matos <pmatos at broadcom dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 Oct 2013 16:44:32 +0200
- Subject: Re: [PATCH] tree_code_name wrapper
- Authentication-results: sourceware.org; auth=none
- References: <19EB96622A777C4AB91610E763265F462DC5C7 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <525C1786 dot 5030404 at oracle dot com> <CAFiYyc0b7fU=L28_rkfo4x0zQ-wkf=tr+APMuXd3DVNw5FGAHQ at mail dot gmail dot com> <19EB96622A777C4AB91610E763265F462DC8D3 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <20131015095055 dot GM30970 at tucnak dot zalov dot cz> <19EB96622A777C4AB91610E763265F462DDBA3 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <CAFiYyc3cGgm80BbKFONoVEw33Zj5LHO6wygY+1Ze9Lwxk5vz0w at mail dot gmail dot com> <19EB96622A777C4AB91610E763265F462DDCB1 at SJEXCHMB14 dot corp dot ad dot broadcom dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
The ChangeLog is still wrong:
On Tue, Oct 15, 2013 at 02:38:31PM +0000, Paulo Matos wrote:
> 2013-10-15 Paulo Matos <pmatos@broadcom.com>
>
> gcc/
> * tree-core.h: Remove extern declaration of tree_code_name.
* tree-core.h (tree_code_name): Remove.
(or Remove external declaration. etc.).
> * tree.h: Prototype for new function get_tree_code_name.
* tree.h (get_tree_code_name): New prototype.
> * tree.c: Make tree_code_name static. Define new function
> wrapper get_tree_code_name.
* tree.c (tree_code_name): Make static.
(get_tree_code_name): New function.
> (dump_tree_statistics, tree_check_failed, tree_not_check_failed,
> tree_class_check_failed, tree_range_check_failed, tree_not_class_check_failed,
Line length 80 characters.
> omp_clause_check_failed, tree_contains_struct_check_failed,
> tree_operand_check_failed): Use new wrapper get_tree_code_name instead of
What is the extra tab after : for?
> calling tree_code_name directly.
> * tree-vrp.c (dump_asserts_for): Likewise.
> * tree-dump.c (dequeue_and_dump): Likewise.
> * tree-pretty-print.c (do_niy, dump_generic_node): Likewise.
> * tree-pretty-print.h (pp_unsupported_tree): Likewise.
> * lto-streamer-out.c (lto_write_tree, DFS_write_tree): Likewise.
> * tree-ssa-dom.c (print_expr_hash_elt): Likewise.
> * gimple-pretty-print.c (dump_unary_rhs, dump_binary_rhs, dump_ternary_rhs,
Line length.
> dump_gimple_assign, dump_gimple_cond, dump_gimple_omp_for): Likewise.
> * tree-vect-data-refs.c (vect_create_data_ref_ptr): Likewise.
> * tree-ssa-pre.c (print_pre_expr): Likewise.
> * ipa-prop.c (ipa_print_node_jump_functions_for_edge): Likewise.
> * print-tree.c (print_node_brief, print_node): Likewise.
> * gimple.c (gimple_check_failed): Likewise.
> * lto-streamer.c (lto_tag_name, print_lto_report): Likewise.
>
> gcc/cp/
> * error.c (code_to_string): Use new wrapper get_tree_code_name.
> * cxx-pretty-print.c (pp_cxx_assignment_operator): Likewise.
> * pt.c (tsubst): Likewise.
> * semantics.c (cxx_eval_constant_expression, potential_constant_expression_1): Likewise.
Again.
> * mangle.c (MANGLE_TRACE_TREE, dump_substitution_candidates, add_substitution,
Again.
> find_substitution): Likewise.
>
> gcc/config/
There is no ChangeLog file in gcc/config/ subdirectory, so these should be
* config/frv/frv.c ... etc. in the gcc/ part of the ChangeLog.
> * frv/frv.c (frv_init_cumulative_args): Use new wrapper get_tree_code_name.
Again.
> * mep/mep.c (mep_validate_vliw): Likewise.
> * iq2000/iq2000.c (init_cumulative_args): Likewise.
> * rs6000/rs6000.c (init_cumulative_args): Likewise.
Jakub