This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ Patch] PR 58633


Hi,

On 10/09/2013 03:56 PM, Jason Merrill wrote:
On 10/08/2013 07:03 PM, Paolo Carlini wrote:
.. a curiosity: the cp_parser_commit_to_tentative_parse at the end of
cp_parser_pseudo_destructor_name, which didn't exist in 4.6.x and we can
consider the root of this issue, is also my fault:

     http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02246.html

 From a different angle, I'm happy of the outcome of this detective
work, because it means that the parser_commit isn't there for
correctness: not performing it in some cases shouldn't be a big issue.

Yeah. I don't understand why cp_parser_commit_to_tentative_parse commits all levels, rather than just the current one as the comment seems to suggest. Mark, do you remember anything about that decision?
Well, the below appears to work for the testcase at issue and even appears to pass the testsuite. Not sure how far we want to go at this time, what should we double chech...

Paolo.

//////////////////////

Attachment: patch_58633_3
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]