This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Cleanup patches


Hi!

On Wed, 9 Oct 2013 11:04:29 +0200, Jakub Jelinek <jakub@redhat.com> wrote:
> The testing _OPENMP value against 201107 won't work after merge, it will be
> 201307 instead.  The Fortran openmp_version will be still 201107 for now,
> as Fortran OpenMP 4.0 support isn't there yet.

And:

On Wed, 9 Oct 2013 11:13:38 +0200, Tobias Burnus <tobias.burnus@physik.fu-berlin.de> wrote:
> * When Jakub's patch gets it, one needs to update the C/C++ OpenMP version
> number for OpenMPv4 (i.e. 201307 instead of 201107). The Fortran
> version number hasn't been bumped, yet.

Sorry for not pointing this out upfront: I've been aware of that, but
posted the patch I had tested based on yesterday's trunk.


> * gfortran's preprocessor also defines _OPENMP. Thus, you could also add
> test cases for _OPENMP.

That's what I'm testing in the new file
gcc/testsuite/gfortran.dg/openmp-define-3.f90 -- anything I'm missing
there?


GrÃÃe,
 Thomas

Attachment: pgpA9o9TUCVrr.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]