This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] alternative hirate for builtin_expert


On Fri, Oct 4, 2013 at 11:54 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>> I looked at this problem. Bug updated
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58619
>>
>> This is a bug when updating block during tree-inline. Basically, it is
>> legal for *n to be NULL. E.g. When gimple_block(id->gimple_call) is
>> NULL, remap_blocks_to_null will be called to set *n to NULL.
>
> The NULL in gimple_block (gimple_call) comes from the call introduced by ipa-split?

That is correct.

> I remember that ipa-split used to try to put the call into block since we was ICEing
> in similar ways previously, too.  Perhaps this has changed with new BLOCK representation?

The new BLOCK representation does not change this. I think it makes
sense to leave the block of newly introduced call_stmt as NULL because
when it's inlined back, we don't want to add additional block layers.

Dehao

>
> Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]