This is the mail archive of the
mailing list for the GCC project.
Re: [Patch] Internal functions for testsuite in regex
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 04 Oct 2013 18:14:41 +0200
- Subject: Re: [Patch] Internal functions for testsuite in regex
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifDmLY-=nJa8dNcsduTgWN2fT1PJ7bu9JEDqYdQCcyqC2JA at mail dot gmail dot com> <524EE6F2 dot 3080906 at oracle dot com>
On 10/04/2013 06:04 PM, Paolo Carlini wrote:
In particular, the new *_testsuite functions, isn't immediately clear
in what they differ from the non-_testsuite variants. In any case we
should figure out a better name, maybe even *_internal, if we can't
find anything more accurate, but it should be self-explaining in terms
of their C++ semantics.
Thus, the functions are comparing two different executors. Thus say that
in the name, like: __regex_search_debug, or __regex_search_compare. And
please say what they are for in a comment before at least the "primary"
overload, the one actually carrying out the comparison.
All the other comments live.