This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] More tree-flow.h prototypes.


On 10/02/2013 03:09 PM, Tobias Burnus wrote:
This patch (rev. 203118) seems to break bootstrapping with Graphite:

g++ -c -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc -I../../gcc/. -I../../gcc/../include -I../../gcc/../libcpp/include -I../../gcc/../libdecnumber -I../../gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/../libbacktrace -DCLOOG_INT_GMP -o ipa-devirt.o -MT ipa-devirt.o -MMD -MP -MF ./.deps/ipa-devirt.TPo ../../gcc/ipa-devirt.c ../../gcc/graphite-sese-to-poly.c: In function 'void rewrite_cross_bb_scalar_dependence(scop_p, tree, tree, gimple)': ../../gcc/graphite-sese-to-poly.c:2348:31: error: 'replace_exp' was not declared in this scope
       replace_exp (use_p, name);
                               ^
../../gcc/graphite-scop-detection.c: In function 'void canonicalize_loop_closed_ssa(loop_p)': ../../gcc/graphite-scop-detection.c:1335:26: error: 'replace_exp' was not declared in this scope
   replace_exp (use_p, res);
                          ^
make[3]: *** [graphite-sese-to-poly.o] Error 1


Tobias

    * tree-flow.h: Remove some prototypes.
    * gimple-fold.h: Add prototypes from gimple.h and tree-flow.h.
    * tree-ssa-propagate.h: Relocate prototypes from tree-flow.h.
    * tree-ssa-copy.c (may_propagate*, propagate_value, replace_exp,
    propagate_tree_value*): Move from here to...
* tree-ssa-propagate.c (may_propagate*, propagate_value, replace_exp,
    propagate_tree_value*): Relocate here.
    * tree-ssa-propagate:h: Relocate prototypes from tree-flow.h.
* gimple.h: Include gimple-fold.h, move prototypes into gimple-fold.h.
    * gimple-fold.c: Remove gimple-fold.h from include list.
    * tree-vrp.c: Remove gimple-fold.h from include list.
    * tree-ssa-sccvn.c: Remove gimple-fold.h from include list.
    * tree-ssa-ccp.c: Remove gimple-fold.h from include list.
    * tree-scalar-evolution.c: Add tree-ssa-propagate.h to include list.
    * tree-ssa-pre.c: Add tree-ssa-propagate.h to include list.
    * sese.c: Add tree-ssa-propagate.h to include list.


I did scratch rebuilds and didn't run into any problem.. and it compiles right now for me... hmmm

00000h,  I see, the entire file is wrapped by
#ifdef HAVE_cloog
<...>
#endif

so If I am compiling without cloog (which I am) then the entire file becomes basically nothing... and thus compiles fine.

I'm guessing graphite-sese-to-poly.c has a similar problem since part of the file is wrapped like that...
That seems like a somewhat hazardous situation :-P.

anwyay, both files should have #include "tree-ssa-propagate.h" then I guess. I don't have cloog so can't test it, can you verify that works?

Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]