This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR55469 - fix I/O memory leaks in case of failure and iostat= being present
- From: Tobias Burnus <burnus at net-b dot de>
- To: gcc patches <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>, Jerry DeLisle <jvdelisle2 at gmail dot com>
- Date: Tue, 01 Oct 2013 22:53:58 +0200
- Subject: Re: [Patch, Fortran] PR55469 - fix I/O memory leaks in case of failure and iostat= being present
- Authentication-results: sourceware.org; auth=none
- References: <50B39C70 dot 9010304 at net-b dot de> <50B7492B dot 5030702 at net-b dot de>
I have committed the patch after Janne's approval on IRC and fresh
building/regtesting as Rev. 203086. See
http://gcc.gnu.org/ml/fortran/2012-11/msg00092.html
As suggested by Janne, I will backport it to 4.8 in in a bunch of days.
Tobias
On November 29, 2012 12:38, Tobias Burnus wrote:
Tobias Burnus wrote:
l_push_char allocates memory which is freed with free_line. However,
currently, the memory is not always freed when calling
generate_error. If one aborts, that's fine. However, generate_error
can also set the iostat variable.
Updated version: Corrected PR number - and ensured that if
convert_real fails, free_saved is called (cf. additional test case in
the PR).
Build and regtested on x86-64-gnu-linux.
OK for the trunk?
Tobias