This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: GCC Testsuite: Annotate compile tests that need at least 32-bit pointers/integers


Hi Mike,

It may be reasonable to special case ptr32plus to say no on your platform, from check_effective_target_tls_native, we see code like:

you could do something like:

proc check_effective_target_ptr32plus { } {
     # msp430 never really has 32 or more bits in a pointer.
     if { [istarget msp430-*-*] } {
         return 0
     }
     return [check_no_compiler_messages ptr32plus object {
         int dummy[sizeof (void *) >= 4 ? 1 : -1];
     }]
}

Then, you don't have to worry about people adding tests with this predicate and those test cases failing.  I don't have a good handle on wether this is better or not, so, I'll let you decide what you think is best.

Thanks - that is a good idea. (I am embarrassed that I did not think of it myself). I have checked the patch in with this change added.

Cheers
  Nick



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]