This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] Fix PR target/58423
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Zhenqiang Chen <Zhenqiang dot Chen at arm dot com>
- Cc: Yufeng Zhang <Yufeng dot Zhang at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 26 Sep 2013 13:22:59 +0100
- Subject: Re: [PATCH, ARM] Fix PR target/58423
- Authentication-results: sourceware.org; auth=none
- References: <CACgzC7C7OYMmT+4Q+_=AzYyeJ0TEcbtKR5DphjNycbV5y_kJ7A at mail dot gmail dot com> <523FEA95 dot 6010603 at arm dot com> <000501ceb834$90c9af70$b25d0e50$ at arm dot com> <52405A13 dot 6020103 at arm dot com> <785717E14D1EB347AD3952AFAE76B36745D3BF4969 at SAROVARA dot Asiapac dot Arm dot com>
On 26/09/13 09:50, Zhenqiang Chen wrote:
>
>
>> -----Original Message-----
>> From: Richard Earnshaw
>> Sent: Monday, September 23, 2013 11:11 PM
>> To: Zhenqiang Chen
>> Cc: Yufeng Zhang; gcc-patches@gcc.gnu.org
>> Subject: Re: [PATCH, ARM] Fix PR target/58423
>>
>> On 23/09/13 09:11, Zhenqiang Chen wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
>>>> owner@gcc.gnu.org] On Behalf Of Yufeng Zhang
>>>> Sent: Monday, September 23, 2013 3:16 PM
>>>> To: gcc-patches@gcc.gnu.org
>>>> Subject: Re: [PATCH, ARM] Fix PR target/58423
>>>>
>>>> On 09/23/13 07:58, Zhenqiang Chen wrote:
>>>>> --- clean-trunk/gcc/config/arm/arm.c 2013-09-17 14:29:45.632457018
>>>> +0800
>>>>> +++ pr58423/gcc/config/arm/arm.c 2013-09-18 14:34:24.708892318
>> +0800
>>>>> @@ -17645,8 +17645,8 @@
>>>>> mem = gen_frame_mem (DImode, stack_pointer_rtx);
>>>>>
>>>>> tmp = gen_rtx_SET (DImode, gen_rtx_REG (DImode, j), mem);
>>>>> - RTX_FRAME_RELATED_P (tmp) = 1;
>>>>> tmp = emit_insn (tmp);
>>>>> + RTX_FRAME_RELATED_P (tmp) = 1;
>>>>
>>>> The indent doesn't seem right.
>>>
>>> Thanks for the comments. My gmail server changes "tab" to "4 spaces".
>>>
>>> Recreate the patch to remove "tab" and use attachment to make sure no
>>> other automatic changes.
>>>
>>
>> Please fix your mailer. The GNU coding standard uses hard tabs and
>> gratuitous changes to the white space are a pain to deal with.
>
> Thanks for the comments. Patch is updated to use hard tabs.
>
> -Zhenqiang
>
OK.
R.