This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Trivial cleanup


On 09/25/2013 10:04 AM, Jakub Jelinek wrote:
On Wed, Sep 25, 2013 at 11:46:12AM -0400, Andrew MacLeod wrote:
I noticed that with the wrapper conversion, often you will get a
sequence of 3 or more method calls, and its quite unbearable to have
the spaces.
simple things like
   int unsignedsrcp = ptrvar.type().type().type_unsigned();
vs
   int unsignedsrcp = ptrvar.type ().type ().type_unsigned ();

I was going to bring it up at some point too.  My preference is
strongly to simply eliminate the space on methods...

My preference is to keep the spaces, it makes code more readable,
no space before ( looks very ugly to me.
I generally find the lack of a space before the open-paren ugly as well, but I find something like Andrew's example with the horizontal spaces insanely bad.
Jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]