This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Make vector::at() assertion message more useful (try #2)

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: Andreas Schwab <schwab at suse dot de>, Daniel Krügler <daniel dot kruegler at gmail dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Mon, 23 Sep 2013 09:54:49 -0500
Subject: Re: [patch] Make vector::at() assertion message more useful (try #2)
Authentication-results: sourceware.org; auth=none
References: <ye6qhae0qpf8 dot fsf at elbrus2 dot mtv dot corp dot google dot com> <CAGNvRgDfHf6pYmBYC66HHhj6RobhiaiAAVEKj1FDxSWGxbYFTg at mail dot gmail dot com> <CALoOobMf3u8R_DVW5b2eRy05fBpB5unhriLMYdUEkT_E3DwtaA at mail dot gmail dot com> <CAGNvRgD6mK=-n7QhK=-NtfXZHOpCniXKc-riWUNfqZeVa8xufQ at mail dot gmail dot com> <CALoOobO6XEsrSM6jJFCQ=n00iY8qM=eujs-=LixNZyuya5f-cA at mail dot gmail dot com> <5232E2AF dot 4000106 at oracle dot com> <CALoOobMejGJLVVCszP8Joa+4B21UbvK4chyFUnjiCNPP0GJF0A at mail dot gmail dot com> <mvma9j35377 dot fsf at hawking dot suse dot de> <52402567 dot 2080407 at oracle dot com> <524054C8 dot 3010502 at google dot com>

Hi,

On 9/23/13 9:48 AM, Paul Pluzhnikov wrote:

On 9/23/13 4:26 AM, Paolo Carlini wrote:

m68k-linux/./libstdc++-v3/src/.libs/libstdc++.so: undefined reference
to `int std::__int_to_char<char, unsigned int>(char*, unsigned int,
char const*, std::_Ios_Fmtflags, bool)'


Reproduced on i686.
Sorry about the trouble ...

I would say, either make sure to use only those two in the new
code


Testing this patch:

In fact, however, that unsigned long long instantiation isn't*unconditionally* available, see locale-inst.cc. I think we have to useunsigned long as a fall back controlled by the same macro. And pleaseadd a comment explaining those contortions having to do with theavailable instantiations. Patch pre-approved.


Thanks again,
Paolo.

Follow-Ups:
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paul Pluzhnikov

References:
- [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paul Pluzhnikov
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Daniel Krügler
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paul Pluzhnikov
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Daniel Krügler
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paul Pluzhnikov
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paolo Carlini
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paul Pluzhnikov
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Andreas Schwab
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paolo Carlini
- Re: [patch] Make vector::at() assertion message more useful (try #2)
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]