This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH] ICE with combination of -fopenmp and -femit-struct-debug-reduced/baseonly
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: Cary Coutant <ccoutant at google dot com>, Evgeny Gavrin <e dot gavrin at samsung dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, GarbuzovViacheslav <v dot garbuzov at samsung dot com>
- Date: Wed, 18 Sep 2013 12:39:22 +0200
- Subject: Re: [PING][PATCH] ICE with combination of -fopenmp and -femit-struct-debug-reduced/baseonly
- Authentication-results: sourceware.org; auth=none
- References: <000a01ceafb1$85e48020$91ad8060$%gavrin at samsung dot com> <CAHACq4r8gqg2jM2EiTpnzcuZ9rr+y6AqUHJor+m+N2PORTfEMw at mail dot gmail dot com> <523981AF dot 9080102 at arm dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Sep 18, 2013 at 11:34:23AM +0100, Kyrill Tkachov wrote:
> Hi Cary, Evgeny
> On 13/09/13 23:38, Cary Coutant wrote:
> >>Iâve attached fix for this issue:
> >>http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57737
> >>There are fix, two tests and change log message.
> >>
> >>Is it ok?
> >>
> >>Cary, can you commit it for me?
> >>
> >>Ping this patch, http://gcc.gnu.org/ml/gcc-patches/2013-07/msg00053.html
> >Thanks for the fix, and sorry for the delay! I've committed it for you
> >at r202582.
> The tests should be guarded to not run on targets
> that don't support openmp, such as bare metal targets.
>
> This patch adds an effective target check for openmp.
>
> Ok to apply?
Yes, with appropriate ChangeLog entry.
> --- a/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
> +++ b/gcc/testsuite/g++.dg/debug/dwarf2/omp-fesdr.C
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target fopenmp } */
> /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */
>
> struct aa
> diff --git a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
> index 005acdf..d7b0319 100644
> --- a/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
> +++ b/gcc/testsuite/gcc.dg/debug/dwarf2/omp-fesdr.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-require-effective-target fopenmp } */
> /* { dg-options "-g -fopenmp -gdwarf-2 -femit-struct-debug-reduced" } */
>
> struct aa
Jakub