This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS


On Sep 16, 2013, at 2:09 AM, Richard Biener <richard.guenther@gmail.com> wrote:
>> Here is the patch to add precision to partial int modes.  I included switching over the rs6000 port to the new scheme so one can get a feel for that it would look like.

> Can you instead of adding PARTIAL_INT_MODE_N change all existing
> PARTIAL_INT_MODE ()s to PARTIAL_INT_MODE_LEGACY () and change
> PARTIAL_INT_MODE behavior?

Ick.  :-)

> So, if you send a whole conversion patch then we don't have to play games
> with having both variants recognized.

Yup, let's do that.  I added the ability to name the mode, as that was requested.  20/20 hindsight, the patches to review are way smaller and easier to review because of it, so, I made use of that feature in all the ports.

>  (now it just occurs to me we can use
> a variadic macro here …?)

The variadic macro part scared me.  They are not standard, and no one has mandated gcc or c++11 yet.

This needs an sh expert to review it, I found the web sh descriptions to be lacking.  I'd be nice for all the affected targets to double check no regressions.  sh, rs6000, bfin, m32c, msp430.

Thanks guys.

Attachment: partial.diffs.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]