This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Uros, Thanks for your review. I attached modified patch - is it OK for you now? 2013/9/16 Uros Bizjak <ubizjak@gmail.com>: > On Mon, Sep 16, 2013 at 2:50 PM, Yuri Rumyantsev <ysrumyan@gmail.com> wrote: >> Hi All, >> >> Here is 1-line fix which improves Atom performance by better distance >> estimation. We got ~20% speedup on one of bench from eembc2.0 with >> this fix. >> >> Bootstrapping and regression testing were successful for x86-64. >> >> Is it OK for trunk? >> >> ChangeLog: >> >> 2013-09-16 Yuri Rumyantsev <ysrumyan@gmail.com> >> >> * config/i386/i386.c (distance_agu_use_in_bb) : Proper initialization >> of 'prev' var to get better distance estimation. > > Please rewrite this part to: > > basic_block bb = NULL; > rtx next = start; > rtx prev = NULL; > > if (start != NULL_RTX) > { > bb = BLOCK_FOR_INSN (start); > if (start != BB_HEAD (bb)) > prev = insn; > } > > A comment would be also nice here. It took me quite some time to > decipher the code. > > OK with these changes. > > Thanks, > Uros.
Attachment:
patch1
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |