This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [buildrobot] [PATCH] r202527: ssa / ssanames restructure broke alpha-linux
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Andrew MacLeod <amacleod at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 16 Sep 2013 11:05:40 +0200
- Subject: Re: [buildrobot] [PATCH] r202527: ssa / ssanames restructure broke alpha-linux
- Authentication-results: sourceware.org; auth=none
- References: <20130914104154 dot GH24834 at lug-owl dot de>
On Sat, Sep 14, 2013 at 12:41 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> Hi!
>
> My Build Robot[1] found this recent commit to break Alpha:
>
> * tree-flow.h (FREE_SSANAMES): Move to tree-ssanames.c
> (SSANAMES, MODIFIED_NORETURN_CALLS, DEFAULT_DEFS, ptr_info_def,
> num_ssa_names, ssa_name): Move to tree-ssanames.h + prototypes.
> * tree-flow-inline.h (make_ssa_name, copy_ssa_name, duplicate_ssa_name,
> make_temp_ssa_name): move to tree-ssanames.h
> * tree-ssa-alias.h: Move prototype.
> * tree-ssa.h: Include tree-ssanames.h.
> * tree-ssanames.c (FREE_SSANAMES): Move to here.
> * tree-ssanames.h: New. Move items from tree-flow*.h
> * Makefile.in (tree-ssanames.h): Add to tree-ssanames.o and GTFILES.
>
> See for example this build log:
> http://toolchain.lug-owl.de/buildbot/showlog.php?id=11663&mode=view
>
> I suggest this patch, which fixes an alpha-linux build for me:
I think you can remove the tree-flow.h include and you need to update the
dependencies in gcc/Makefile.in.
Richard.
> 2013-09-13 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * config/alpha.c: Include tree-ssa.h.
>
> diff --git a/gcc/config/alpha/alpha.c b/gcc/config/alpha/alpha.c
> index a8fb929..3759205 100644
> --- a/gcc/config/alpha/alpha.c
> +++ b/gcc/config/alpha/alpha.c
> @@ -50,6 +50,7 @@ along with GCC; see the file COPYING3. If not see
> #include "splay-tree.h"
> #include "gimple.h"
> #include "tree-flow.h"
> +#include "tree-ssa.h"
> #include "tree-stdarg.h"
> #include "tm-constrs.h"
> #include "df.h"
>
>
> Ok?
>
> MfG, JBG
>
> [1] http://toolchain.lug-owl.de/buildbot/
> http://toolchain.lug-owl.de/buildbot/timeline.php
> --
> Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
> Signature of: If it doesn't work, force it.
> the second : If it breaks, it needed replacing anyway.