This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC - Refactor tree.h


On Thu, Sep 05, 2013 at 11:11:43AM +0200, Richard Biener wrote:
> On Thu, Sep 5, 2013 at 2:06 AM, Mike Stump <mikestump@comcast.net> wrote:
> > On Aug 30, 2013, at 4:22 PM, Diego Novillo <dnovillo@google.com> wrote:
> >> Thanks for the suggestions.  I've incorporated them into the patch.
> >> It now adds tree-core.h with all the structures, enums, typedefs and
> >> some fundamental declarations from tree.h.  Everything else stays in
> >> tree.h for now.
> >
> > So, the comments for the data structures that moved, should also move?!
> >
> > The below moves one comment that I noticed.
> >
> > Ok?
> 
> Ok.

Please, whenever making such big changes, double check that you have
incorporated all the changes that went in since you've started on the
refactoring, otherwise we lose important changes.
E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN
comment that has been added to tree.h recently, but you haven't
actually moved it into tree-core.h.
Makes me wonder how many other changes got lost.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]