This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH GCC] Tweak gimple-ssa-strength-reduction.c:backtrace_base_for_ref () to cover different cases as seen on AArch64
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Yufeng Zhang <Yufeng dot Zhang at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "William J. Schmidt" <wschmidt at linux dot vnet dot ibm dot com>, Bin Cheng <Bin dot Cheng at arm dot com>
- Date: Wed, 11 Sep 2013 10:32:15 +0200
- Subject: Re: [PATCH GCC] Tweak gimple-ssa-strength-reduction.c:backtrace_base_for_ref () to cover different cases as seen on AArch64
- Authentication-results: sourceware.org; auth=none
- References: <522F4092 dot 1040100 at arm dot com>
On Tue, Sep 10, 2013 at 5:53 PM, Yufeng Zhang <Yufeng.Zhang@arm.com> wrote:
> Hi,
>
> Following Bin's patch in
> http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00695.html, this patch tweaks
> backtrace_base_for_ref () to strip of any widening conversion after the
> first TREE_CODE check fails. Without this patch, the test
> (gcc.dg/tree-ssa/slsr-39.c) in Bin's patch will fail on AArch64, as
> backtrace_base_for_ref () will stop if not seeing an ssa_name since the tree
> code can be nop_expr instead.
>
> Regtested on arm and aarch64; still bootstrapping x86_64.
>
> OK for the trunk if the x86_64 bootstrap succeeds?
Please add a testcase.
Richard.
> Thanks,
> Yufeng
>
> gcc/
>
> * gimple-ssa-strength-reduction.c (backtrace_base_for_ref): Call
> get_unwidened and check 'base_in' again.