This is the mail archive of the
mailing list for the GCC project.
Re: [patch] Remove unused macro and functions from tree-flow.h and tree-flow-inline.h
- From: Tom Tromey <tromey at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Andrew MacLeod <amacleod at redhat dot com>, Jeff Law <law at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 10 Sep 2013 08:42:37 -0600
- Subject: Re: [patch] Remove unused macro and functions from tree-flow.h and tree-flow-inline.h
- Authentication-results: sourceware.org; auth=none
- References: <522E6EFE dot 2080602 at redhat dot com> <522E8654 dot 8030505 at redhat dot com> <20130910052746 dot GR1817 at tucnak dot redhat dot com> <522F05B2 dot 5020300 at redhat dot com> <20130910123035 dot GX1817 at tucnak dot redhat dot com> <522F18E9 dot 5030500 at redhat dot com> <20130910131546 dot GY1817 at tucnak dot redhat dot com>
>>>>> "Jakub" == Jakub Jelinek <email@example.com> writes:
Jakub> On Tue, Sep 10, 2013 at 09:04:41AM -0400, Andrew MacLeod wrote:
>> Really? If it were useful I would have thought they'd be using it now.
>> In any case, it doesn't belong in tree-flow.h.. . shouldn't these
>> functions and macros be in hashtab.h then?
Jakub> It doesn't belong to hashtab.h, because that is a libiberty API, this
Jakub> style of iterators is GCC specific.
FWIW I've occasionally wished that these iterators were in libiberty.
Currently the only iteration interface for hashtab is callback-based,
which is a pain. Also it seems to me that the iterators belong in
hashtab so as not to violate the module boundary.