This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Dump framework newline cleanup

looks fine to me.

In the long run, I wonder if the machinery in diagnostic messages can
be reused for opt-info dumping -- i.e., support different streams. It
has many nice features including %qD specifier for printing tree


On Mon, Sep 9, 2013 at 12:01 PM, Teresa Johnson <> wrote:
> I've attached a patch that implements the cleanup of newline emission
> by the new dump framework as discussed here:
> Essentially, I have removed the leading newline emission from
> dump_loc, and updated dump_printf_loc invocations to emit a trailing
> newline as necessary. This will remove unnecessary vertical space in
> the dump output.
> I did not do any other cleanup of the existing vectorization messages
> - there are IMO a lot of messages being emitted by the vectorizer
> under MSG_NOTE (and probably MSG_MISSED_OPTIMIZATION) that should only
> be emitted to the dump file under -fdump-tree-... and not emitted
> under -fopt-info-all. The ones that stay under -fopt-info-all need
> some formatting/style cleanup. Leaving that for follow-on work.
> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk?
> Thanks,
> Teresa
> --
> Teresa Johnson | Software Engineer | | 408-460-2413

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]