This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: crash fix for unhanded operation
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 9 Sep 2013 22:48:54 +0000
- Subject: Re: crash fix for unhanded operation
- Authentication-results: sourceware.org; auth=none
- References: <44C327AE-2328-4322-B792-61F22DFB1588 at comcast dot net>
On Mon, 9 Sep 2013, Mike Stump wrote:
> Presently gcc just dies with a crash for an unhanded operation, the
> below handles it better.
>
> I'm torn between sorry and error, error might be better. Thoughts?
error means there is something wrong with the user's source code, and
should generally be associated with the location of an erroneous source
code construct. I don't see how it can be appropriate here; my impression
is that this code should never fail for any compiler input, valid or
invalid, and so an ICE seems better than sorry (which is for some
well-defined source code feature lacking GCC support, or exceeding
implementation limits in GCC).
--
Joseph S. Myers
joseph@codesourcery.com