This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/6] Andes nds32: machine description of nds32 porting (1).

On 7/25/13 5:35 PM, Chung-Ju Wu wrote:
> On 7/25/13 12:08 AM, Joseph S. Myers wrote:
>> On Wed, 24 Jul 2013, Chung-Ju Wu wrote:
> Attached is another revised patch and its summary.
> The modifications described above are listed as item 11 and 12:
>    1. Remove fancy comments formatting.
>    2. Sort static functions and variables and put the target hook
>       structure initialization at the end of the file.
>    3. Avoid all comments referring to section numbers.
>    4. Use snprintf () instead of sprinf ().
>    5. Use sorry () instead of error () for unimplemented functionalities.
>    6. Do not check command options error in nds32.h.
>      Use Negative() in nds32.opt instead.
>    7. Remove %{v} from LINK_SPEC.
>    8. Add OPTION_DEFAULT_SPECS for -march option.
>    9. Enable/disable corresponding flags internally for -march= option.
>   10. Add MULTILIB_DEFAULTS for multilib endianness.
>   11. Use form-feeds (Control-L character) to separate logical sections.
>   12. The nds32_intrinsic_register_names[] array itself can be made const.

It has been a while since last v2 patch.
I create a new v3 patch to fix some typo and indentation.

Is it OK to apply on the trunk?

Best regards,

Attachment: 2-nds32-backend-md-part1.v3.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]