This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [diagnostic patch] PR 54941


Hi Gaby,

On 09/08/2013 03:41 PM, Gabriel Dos Reis wrote:
On Sun, Sep 8, 2013 at 8:00 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
Hi all, Gaby,

in this bug Manuel noticed that the zeros in the diagnostic lines of the
form:

<built-in>:0:0: ....

don't provide useful information. Thus the below just avoids printing the
zeros basing directly on the file name: admittedly, it may seem a bit gross,
but in practice the strcmp would often fail early, and should be rather
efficient anyway because the second argument is known at compile-time.
For builtins, we probably do not want to print the line number
and the column number (both of which are zero).
I agree. This is exactly what my patch does, isn't it?

Thanks,
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]