This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

On 5 September 2013 13:02:29 Kirill Yukhin <> wrote:
On 04 Sep 20:11, Maxim Kuvyrkov wrote:
> On 4/09/2013, at 7:43 PM, Alexander Ivchenko wrote:
> The patch is OK with definitions of OPTION_GLIBC, OPTION_UCLIBC and OPTION_BIONIC copied verbatim from gcc/config/l

Checked into main trunk:

Unless i am missing something crucial I am not really convinced that this bionic support stuff you guys are aiming at is proper, to be defensive..

uClibc has C99 math support optionally as well as other optional, nonstandard feature sets. Your patch does not seem to check (in a cross-compilable fashion, of course) if C99 math is supported in libc or not, thus regressing on uClibc with C99_MATH enabled.

Please revert this patch and handle your libc in a sensible manner as everyone else has to since years.. I.e. either be C99 complete or fixup your conditions, ideally in the public port.


Thanks, K

Sent with AquaMail for Android

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]