This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Teresa Johnson <tejohnson at google dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, Rong Xu <xur at google dot com>, Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Steven Bosscher <stevenb dot gcc at gmail dot com>, Jeff Law <law at redhat dot com>, "marxin.liska" <marxin dot liska at gmail dot com>, Sriraman Tallam <tmsriram at google dot com>
- Date: Fri, 30 Aug 2013 17:26:38 +0200
- Subject: Re: [PATCH] Sanitize block partitioning under -freorder-blocks-and-partition
- Authentication-results: sourceware.org; auth=none
- References: <20130817204408 dot GA16557 at kam dot mff dot cuni dot cz> <CAAe5K+XGKvd+_8Ukp0kpOWvc2k165F=4fdemf-iDz+QkirLPmg at mail dot gmail dot com> <20130819150942 dot GA28264 at kam dot mff dot cuni dot cz> <CAAe5K+UnqBfxYrZxSkjRudq8NYni_9ih+t=us+2hH+UPsrwDLA at mail dot gmail dot com> <CAAe5K+UhCzfwm_WomE1yk+ET1tBiNT5svfn_LAc57MUSqJbnaQ at mail dot gmail dot com> <20130828165830 dot GC12167 at kam dot mff dot cuni dot cz> <CAAe5K+U5VCoZQSGKxTs5yYKO6fM1wkbpBBtgS8ZFpKywQkCrbg at mail dot gmail dot com> <CAAe5K+XwXbpFJeqdcxj9Ua1XcBLpfs_32ogqmjUaLUxSS17p6w at mail dot gmail dot com> <20130830091414 dot GA877 at kam dot mff dot cuni dot cz> <CAAe5K+X5jzW5mnOvoS6PFbKJpOLOmMicwG1mFGGOJ_AxoUm6Jg at mail dot gmail dot com>
> >
> > The frequency condition needs to be done only when you walk predecestors - when
> > you walk down the edge probabilities are just fine.
>
> True. For simplicity I think it should be fine to leave as-is so there
> isn't more special casing as the current approach works in both
> directions.
Yep, you are right. Frequencies are safe both directions.
I think this change belongs to profile feedback category, so the patch is OK.
Honza