This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, vtv update] Change fixed size array to a vector; fix diagnostic messages.


On Wed, Aug 28, 2013 at 1:39 PM, Caroline Tice <cmtice@google.com> wrote:

> num_vtable_args  was an int that we manually incremented/decremented,
> so it might have been negative.  I am
> assuming that a vec<tree>.length() can never be negative. So before
> the else-clause was explicitly checking that the value was 0 or 1
> (since the if-condition takes all values greater than 1.  Now I am
> implicitly assuming that when we get to the else-clause the value must
> be 0 or 1, because the if-condition took care of all values greater
> than 1, and values less that zero cannot occur.  Is that assumption
> incorrect?

Ah, thanks.

> Do you need to review this again after I fix your suggestion, or can I
> go ahead and commit it after?

No. If the changes bootstrap and pass validation, you can commit the
modified patch.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]